-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add short option fix for #3798, fix bug in test/SCONSFLAGS.py, fix space issue from #3436 #3799
base: master
Are you sure you want to change the base?
Conversation
This is nice work, got a lot further than my attempts to dig at this. Haven't had time to deep dive and/or think about the fiddling with SCons variables, but the evidence from the tests is promising. If this does go forward, someone will have to undo some of the doc warnings that were recently added to "don't do that" (nargs > 1, space separators). Also we should hunt down and tie in all the github issues that mention this problem, there are quite a few - at least the ones noted in #3436, there may be others too. |
…emove_Argument logic that would prevent the correct argument value from getting returned.
Looks like test: |
So this test line:
seems to indicate
|
This ended up sitting for a long time. @bdbaddog - in terms of at least fixing #3798, would it be more palatable to pick just that part of this PR and submit it separately? The absence of an overridden AddOption(
"-F",
"--force",
action="store_true",
help="force installation (overwrite any existing files)",
) Would fail with a "no such option", if you |
this is attacking two problems: single-char args, and the problem with args-with-options using space(s); figured it would be easier to get you happy with one at a time? |
Override the _process_short_opts method from optparse so it behaves better. This fix is lifted directly from SCons#3799, leaving an additional part to apply later. Fixes SCons#3798 Signed-off-by: Mats Wichmann <[email protected]>
Contributor Checklist:
CHANGES.txt
(and read theREADME.rst
)Fixes issue #3798
Fixes issue #3436